Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random cleanups and fix clippy #25

Merged
merged 4 commits into from
Nov 28, 2023
Merged

random cleanups and fix clippy #25

merged 4 commits into from
Nov 28, 2023

Conversation

alindima
Copy link
Contributor

@alindima alindima commented Nov 27, 2023

closes #16

@alindima alindima requested a review from ordian November 27, 2023 16:02
@alindima alindima changed the title random cleanups random cleanups and fix clippy Nov 27, 2023
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Install `cargo install cargo-hongg` and run with:

```sh
cargo-hongg fuzz --bin <binary_name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be reed-solomon-benches instead of <binary_name>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, should be one of

fuzz_reconstruct
fuzz_roundtrip
fuzz_additive_mpy
fuzz_afft
fuzz_inverse_afft

I didn't hardcode the list here as it may change in the future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, pre-coffee state 😅

@ordian ordian merged commit 714195a into master Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix clippy warnings
2 participants