Added tip support #942

niklabh · 2020-06-19T20:18:48Z

Closes: #914

niklabh · 2020-06-24T10:29:55Z

Have opened it up for review. Do we need to create new notification settings in jwt for tip posts. Isn't new_proposal sufficient?
Need some help with BalanceInput @Tbaut while endorsing tip from sidebar. For some reason cannot enter any numeric value there. Can only enter 0 or letters. Can't seems to find the reason why.

Tbaut · 2020-06-24T11:26:38Z

Sure I'll take a look.

Tbaut · 2020-06-24T12:24:19Z

Isn't new_proposal sufficient?

You're right, no need to be too granular, new proposals does the job.

One quick thing I see right away from your screenshot, the reason is an encoded string. It should be decoded in the UI. and the Finder is an account, so it should be displayed as such.

Tbaut

Wow that's a big one! I tried to play with it, but stopped when I realized my hasura was failing over and over because the remote schema didn't contain tip. I guess you're still using 4466 in your docker-compose, for HASURA_CHAIN_DB_REMOTE_SCHEMA, whereas you should have http://localhost:4000, like in test and prod. And this brings us to the fact that the open-server needs new resolver to cater for the new tips (I forgot about it in the issue, just added it).

I went briefly through the code, catching small things here and there. I'll review everything again thoroughly once again and play with it. I checked briefly the input code, couldn't spot any problem at first glance, I'll leave that for my next review as well, when things are running end to end.

node-watcher/docker-compose.yml

chain-db-watcher/README.md

chain-db-watcher/src/graphql_helpers.ts

front-end/src/components/Post/Post.tsx

front-end/src/screens/Home/LatestTips/index.tsx

front-end/src/screens/OnChain/Tips/query.ts

node-watcher/src/tasks/createTip.ts

Co-authored-by: Thibaut Sardan <[email protected]>

* squash and migrate to v2 * remove useless users mention * remove first useless proposals table creation * delete consecutive add drop column proposal_id * delete consecutive add drop creation and modification_date * delete consecutive add drop on reply * delete consecutive add drop on public.reactions * delete consecutive add drop on public.post_votes * delete consecutive add drop on public.post.poll_id and public.post.has_poll * delete consecutive add drop updated at public.poll and poll_votes * fix tons of nits to make migration sucessful * fix wrong uppercase * remove auto-migration (not-working) and update readme * delete migration_backup and add cron_triggers.yaml

niklabh · 2020-07-08T16:41:09Z

This must be in the tip creation, the data for the finder is :

{
  "data": {
    "tips": [
      {
        "hash": "0x38107ef91f4a1aca157e19dfe8d97386e51ffe9e7a1a9b3bc4cb1736794c8897",
        "who": "5DwXnSMVwLXBZoEfJDw9LMXAb1Q4pv1yp8DrFzNWqAzuJHPo",
        "finder": "[\"5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y\",186666666658]"
      }
    ]
  }
}

Fixed with ugly hack for now

Tbaut

A couple comments to make sure we stay consistent on the node-watcher side to prevent bugs

node-watcher/src/tasks/createTipStatus.ts

node-watcher/src/util/statuses.ts

front-end/src/global/statuses.ts

Tbaut

Small nits here and there, I'll commit them. I want to test the tip endorsement on a new node, which I haven't done yet, and then it should be good to go.

chain-db-watcher/src/sync/index.ts

chain-db-watcher/src/sync/queries/chain-db.queries.ts

chain-db-watcher/src/queries.ts

front-end/src/components/Listings/TipListing.tsx

front-end/src/components/Post/Post.tsx

front-end/src/screens/Tips/index.tsx

Co-authored-by: Thibaut Sardan <[email protected]>

Tbaut

🎉 🎉 🎉
working well on 0.8.14.

We've added some hacks, but it's a VERY complete, thank you so much for all this work.

* Added tip schema * Tip being added to prisma * added chain db watcher and frontend * Added tip proposal * Added Tip to frontend * Added tip section * Added finder * Added chain db watcher for tip * remove who * Added types in refetch * Added endorse sidebar * Added tip type for new proposal emai; * fix * Update chain-db-watcher/README.md Co-authored-by: Thibaut Sardan <[email protected]> * Update chain-db-watcher/README.md Co-authored-by: Thibaut Sardan <[email protected]> * chain db open serve modifications for tip * removed endorsements * removed datamodel * yarn generate * removed endorsements * fix * fix * sidebar component * fix * removed code * fix graphql codegen * correct tip reason * allow numbers * Added time to block * added status update for tips * create tip status * showing only opened status * codegen * fix * added tip closes * fix finder * show only open ones * Hasura migration to v2 and squash (paritytech#950) * squash and migrate to v2 * remove useless users mention * remove first useless proposals table creation * delete consecutive add drop column proposal_id * delete consecutive add drop creation and modification_date * delete consecutive add drop on reply * delete consecutive add drop on public.reactions * delete consecutive add drop on public.post_votes * delete consecutive add drop on public.post.poll_id and public.post.has_poll * delete consecutive add drop updated at public.poll and poll_votes * fix tons of nits to make migration sucessful * fix wrong uppercase * remove auto-migration (not-working) and update readme * delete migration_backup and add cron_triggers.yaml * ugly hack * proper closing and closed display * Added check for closing * added more check * fix * fix * Change status name * tip openend * Update chain-db-watcher/src/sync/index.ts Co-authored-by: Thibaut Sardan <[email protected]> * Update chain-db-watcher/src/sync/queries/chain-db.queries.ts Co-authored-by: Thibaut Sardan <[email protected]> * Update front-end/src/screens/Tips/index.tsx * Update front-end/src/screens/Tips/index.tsx * Update front-end/src/components/Listings/TipListing.tsx * Update front-end/src/screens/Tips/index.tsx * Update chain-db-watcher/src/queries.ts * closing shouldnot show negative days Co-authored-by: Thibaut Sardan <[email protected]> Co-authored-by: thib <[email protected]> Co-authored-by: Nikhil Ranjan <[email protected]>

niklabh added 13 commits June 20, 2020 01:38

Added tip schema

56fa7b3

Tip being added to prisma

84b8aa0

added chain db watcher and frontend

a9f74e9

Added tip proposal

f676e50

Added Tip to frontend

945a014

Added tip section

d131a5d

Added finder

b7958e1

Added chain db watcher for tip

c49670e

remove who

d0e3489

Added types in refetch

ea67389

Added endorse sidebar

aab6889

Added tip type for new proposal emai;

90ccf56

fix

eb588f8

niklabh requested review from Tbaut and erler June 24, 2020 10:22

niklabh marked this pull request as ready for review June 24, 2020 10:22

Merge branch 'master' into niklabh-feature-tip

abfe0fb

Tbaut reviewed Jun 24, 2020

View reviewed changes

Tbaut added the PR-6-got comments label Jun 24, 2020

niklabh and others added 8 commits June 25, 2020 01:07

Update chain-db-watcher/README.md

b2fceef

Co-authored-by: Thibaut Sardan <[email protected]>

Update chain-db-watcher/README.md

d650d93

Co-authored-by: Thibaut Sardan <[email protected]>

chain db open serve modifications for tip

5d884f4

removed endorsements

dd310ce

removed datamodel

badf9cd

yarn generate

ec68ce9

removed endorsements

b7d2f3f

fix

e3b7f9c

Tbaut and others added 2 commits July 8, 2020 21:35

ugly hack

7963456

Tbaut and others added 5 commits July 9, 2020 10:38

proper closing and closed display

e8a70a8

Added check for closing

2a4b20d

added more check

1b9cf80

fix

602e1a2

fix

b159cbb

Tbaut reviewed Jul 9, 2020

View reviewed changes

niklabh added 2 commits July 9, 2020 15:34

Change status name

1cb9177

tip openend

9e17ba1

niklabh requested a review from Tbaut July 9, 2020 10:58

niklabh added the PR-1-please review label Jul 9, 2020

Tbaut reviewed Jul 9, 2020

View reviewed changes

niklabh and others added 7 commits July 9, 2020 17:27

Update chain-db-watcher/src/sync/index.ts

1cde7ef

Co-authored-by: Thibaut Sardan <[email protected]>

Update chain-db-watcher/src/sync/queries/chain-db.queries.ts

da1ce20

Co-authored-by: Thibaut Sardan <[email protected]>

Update front-end/src/screens/Tips/index.tsx

ec86732

Update front-end/src/screens/Tips/index.tsx

31b7041

Update front-end/src/components/Listings/TipListing.tsx

84934f1

Update front-end/src/screens/Tips/index.tsx

75011c9

Update chain-db-watcher/src/queries.ts

eee6b52

Tbaut removed the PR-6-got comments label Jul 9, 2020

closing shouldnot show negative days

0fcf433

Tbaut approved these changes Jul 9, 2020

View reviewed changes

Tbaut added PR-7-FUCK YEAH!1 x- changelog-feature and removed PR-1-please review labels Jul 9, 2020

niklabh merged commit 69530bf into master Jul 9, 2020

niklabh deleted the niklabh-feature-tip branch July 9, 2020 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added tip support #942

Added tip support #942

niklabh commented Jun 19, 2020 •

edited

Loading

niklabh commented Jun 24, 2020

Tbaut commented Jun 24, 2020

Tbaut commented Jun 24, 2020 •

edited

Loading

Tbaut left a comment

niklabh commented Jul 8, 2020

Tbaut left a comment

Tbaut left a comment

Tbaut left a comment

Added tip support #942

Added tip support #942

Conversation

niklabh commented Jun 19, 2020 • edited Loading

niklabh commented Jun 24, 2020

Tbaut commented Jun 24, 2020

Tbaut commented Jun 24, 2020 • edited Loading

Tbaut left a comment

Choose a reason for hiding this comment

niklabh commented Jul 8, 2020

Tbaut left a comment

Choose a reason for hiding this comment

Tbaut left a comment

Choose a reason for hiding this comment

Tbaut left a comment

Choose a reason for hiding this comment

niklabh commented Jun 19, 2020 •

edited

Loading

Tbaut commented Jun 24, 2020 •

edited

Loading