Migrate pallet-migrations to use umbrella crate #7209
+42
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
re-gius
added
R0-silent
re-gius
reviewed
Jan 23, 2025
| @@ -13,22 +13,16 @@ targets = ["x86_64-unknown-linux-gnu"] | |||
| [dependencies] | |||
| cfg-if = { workspace = true } | |||
| codec = { features = ["derive"], workspace = true } | |||
| frame = { workspace = true, features = ["experimental", "runtime"]} | |||
There was a problem hiding this comment.
Suggested change
| frame = { workspace = true, features = ["experimental", "runtime"]} | |
| frame = { workspace = true, features = ["runtime"]} |
| use sp_runtime::BoundedVec; | ||
| use frame::testing_prelude::*; | ||
| use frame::deps::sp_core::ConstU32; | ||
| use frame::deps::sp_runtime::BoundedVec; |
There was a problem hiding this comment.
BoundedVec is already in the main prelude and ConstU32 is already in the runtime prelude, so they are both imported in the testing prelude. You can remove these imports.
| @@ -46,7 +46,8 @@ | |||
| #![allow(unused_imports)] | |||
| #![allow(missing_docs)] | |||
|
|
|||
| use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}}; | |||
| // use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}}; | |||
There was a problem hiding this comment.
Remove comments after making sure everything compiles
re-gius
reviewed
Jan 27, 2025
| Pallet as System, | ||
| }; | ||
| use sp_runtime::Saturating; | ||
| use frame::prelude::*; |
There was a problem hiding this comment.
You can remove this, prelude is already in the testing_prelude
| use sp_runtime::BoundedVec; | ||
| use frame::testing_prelude::*; | ||
| use frame::deps::sp_core::ConstU32; | ||
| use frame::deps::sp_runtime::BoundedVec; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504
Polkadot Address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1