Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2409] Backport #7158 #7181

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[stable2409] Backport #7158 #7181

merged 1 commit into from
Jan 15, 2025

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #7158 into stable2409 from lexnv.

See the documentation on how to use this bot.

@lexnv @github-actions
req-resp/litep2p: Reject inbound requests from banned peers (#7158)
85dd476 
This PR rejects inbound requests from banned peers (reputation is below
the banned threshold).

This mirrors the request-response implementation from the libp2p side.
I won't expect this to get triggered too often, but we'll monitor this
metric.

While at it, have registered a new inbound failure metric to have
visibility into this.

Discovered during the investigation of:
#7076 (comment)

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
(cherry picked from commit ef064a3)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 15, 2025
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit f2d9d6e into stable2409 Jan 15, 2025
119 of 186 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7158-to-stable2409 branch January 15, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lexnv lexnv

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorPopelyaev @lexnv