xcm: fix for DenyThenTry Barrier #7169
Merged
+473
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
requested changes
Jan 15, 2025
bkontur
reviewed
Jan 15, 2025
|
@yrong overall looks good so far, I was also thinking about another trait for that like this |
…adot-sdk into fix-for-deny-then-try
Co-authored-by: Francisco Aguirre <[email protected]>
3 tasks
bkontur
reviewed
Jan 16, 2025
bkontur
reviewed
Jan 16, 2025
bkontur
reviewed
Jan 16, 2025
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
…adot-sdk into fix-for-deny-then-try
franciscoaguirre
approved these changes
Jan 24, 2025
| instructions: &mut [Instruction<RuntimeCall>], | ||
| max_weight: Weight, | ||
| properties: &mut Properties, | ||
| ) -> Option<ProcessMessageError>; |
There was a problem hiding this comment.
I understand it better with the Option because seeing Some(_) makes me guess it will be denied but seeing Ok(_) makes me doubt whether or not it's okay to deny or okay to pass.
To clear up all possible misunderstanding we could use a custom enum:
enum DenyResult {
Deny,
DontDeny,
}Might be overkill though.
|
/cmd fmt |
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
|
@acatangiu Please check if there is anything important that I should address for merging. |
raymondkfcheung
approved these changes
Jan 27, 2025
bkontur
reviewed
Jan 27, 2025
|
/cmd fmt |
2 tasks
acatangiu
approved these changes
Jan 27, 2025
Merged
via the queue into
paritytech:master
with commit Jan 27, 2025
b30aa31
202 of 205 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (partially): #7148 (see Problem 1 -
ShouldExecutetuple implementation andDenyfilter tuple)This PR changes the behavior of
DenyThenTryfrom the patternDenyIfAllMatchtoDenyIfAnyMatchfor the tuple.I would expect the latter is the right behavior so make the fix in place, but we can also add a dedicated Impl with the legacy one untouched.
TODO
DenyReserveTransferToRelayChainDenyThenTryas discussed here and update documentation if needed