-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AHM] Adds multi-block election types and refactors current pallets to support new interfaces and types #6034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only looked at traits. Will do another pass.
…into gpestana/epm-mb
Command "bench --pallet pallet_staking" has failed ❌! See logs here Command output:❌ Failed benchmarks of runtimes/pallets: |
/cmd bench --pallet pallet_staking |
Command "bench --pallet pallet_staking" has started 🚀 See logs here |
Command "bench --pallet pallet_staking" has failed ❌! See logs here Command output:❌ Failed benchmarks of runtimes/pallets: |
/cmd fmt |
Command "fmt" has started 🚀 See logs here |
Command "fmt" has finished ✅ See logs here |
/cmd bench --pallet pallet_staking |
Command "bench --pallet pallet_staking" has started 🚀 See logs here |
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
…into gpestana/epm-mb
Command "bench --pallet pallet_staking" has failed ❌! See logs here Command output:❌ Failed benchmarks of runtimes/pallets: |
All GitHub workflows were cancelled due to failure one of the required jobs. |
This PR is in more or less good shape, but fixing its benchmarks would lead to an amount of work that I don't see useful because #7282 will alter more things, and fixing them there would be more fruitful. @Ank4n @tdimitrov if you agree, I will close this, and we will make #7282 the main feature branch of all things staking related? This PR can still be used as a checkpoint to audit part of the code @seadanda. |
If I understand correctly both PRs add multi-block election to staking. I have no preference which one we will use as a feature branch. Out of curiosity - why they both exist? |
This PR refactors the types and structs required to run a mulit-block election and updates the EPM, staking-pallet and all dependent pallets to use the multi-block types. The Westend runtime is configured to run a 1 paged election, which is a noop refactor compared to the current single-block election.
Notable changes since last reviews:
Tasks based on feedback that can be closed after merging this PR: Umbrella ticket for multi-block election tasks to improve after PR#6034.
The multi-block election provider pallet is wip and it's added in a separate PR (#6213).
To-do before merging:
on_intialize
in pallet staking