Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AHM] Adds multi-block election types and refactors current pallets to support new interfaces and types #6034

Closed
wants to merge 120 commits into from

Conversation

gpestana
Copy link
Contributor

@gpestana gpestana commented Oct 13, 2024

This PR refactors the types and structs required to run a mulit-block election and updates the EPM, staking-pallet and all dependent pallets to use the multi-block types. The Westend runtime is configured to run a 1 paged election, which is a noop refactor compared to the current single-block election.

Notable changes since last reviews:

Tasks based on feedback that can be closed after merging this PR: Umbrella ticket for multi-block election tasks to improve after PR#6034.


The multi-block election provider pallet is wip and it's added in a separate PR (#6213).

To-do before merging:

  • test with chopsticks/follow-chain
  • add benchmarks for on_intialize in pallet staking

@gpestana gpestana self-assigned this Oct 13, 2024
@gpestana gpestana requested a review from a team as a code owner October 13, 2024 23:49
@gpestana gpestana requested a review from Ank4n October 13, 2024 23:49
@gpestana gpestana marked this pull request as draft October 13, 2024 23:49
@gpestana gpestana added the T2-pallets This PR/Issue is related to a particular pallet. label Oct 13, 2024
Copy link
Contributor

@Ank4n Ank4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at traits. Will do another pass.

@gpestana gpestana marked this pull request as ready for review October 18, 2024 16:42
Copy link
Contributor

Command "bench --pallet pallet_staking" has failed ❌! See logs here

Command output:

❌ Failed benchmarks of runtimes/pallets:
-- dev: ['pallet_staking']
✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_staking']

@kianenigma
Copy link
Contributor

/cmd bench --pallet pallet_staking

Copy link
Contributor

Command "bench --pallet pallet_staking" has started 🚀 See logs here

Copy link
Contributor

Command "bench --pallet pallet_staking" has failed ❌! See logs here

Command output:

❌ Failed benchmarks of runtimes/pallets:
-- dev: ['pallet_staking']
✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_staking']

@kianenigma
Copy link
Contributor

/cmd fmt

Copy link
Contributor

Command "fmt" has started 🚀 See logs here

Copy link
Contributor

Command "fmt" has finished ✅ See logs here

@kianenigma
Copy link
Contributor

/cmd bench --pallet pallet_staking

Copy link
Contributor

Command "bench --pallet pallet_staking" has started 🚀 See logs here

@kianenigma kianenigma changed the title Adds multi-block election types and refactors current pallets to support new interfaces and types [AHM] Adds multi-block election types and refactors current pallets to support new interfaces and types Jan 23, 2025
Copy link
Contributor

Command "bench --pallet pallet_staking" has failed ❌! See logs here

Command output:

❌ Failed benchmarks of runtimes/pallets:
-- dev: ['pallet_staking']
✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_staking']

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12931586313
Failed job name: run-frame-omni-bencher

@kianenigma
Copy link
Contributor

This PR is in more or less good shape, but fixing its benchmarks would lead to an amount of work that I don't see useful because #7282 will alter more things, and fixing them there would be more fruitful.

@Ank4n @tdimitrov if you agree, I will close this, and we will make #7282 the main feature branch of all things staking related?

This PR can still be used as a checkpoint to audit part of the code @seadanda.

@tdimitrov
Copy link
Contributor

This PR is in more or less good shape, but fixing its benchmarks would lead to an amount of work that I don't see useful because #7282 will alter more things, and fixing them there would be more fruitful.

@Ank4n @tdimitrov if you agree, I will close this, and we will make #7282 the main feature branch of all things staking related?

This PR can still be used as a checkpoint to audit part of the code @seadanda.

If I understand correctly both PRs add multi-block election to staking. I have no preference which one we will use as a feature branch.

Out of curiosity - why they both exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants