refactor(server): make ProxyGetRequestLayer http middleware support multiple path-method pairs
#1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
changed the title
ProxyGetRequest http middleware support multiple path-method pairsProxyGetRequestLayer http middleware support multiple path-method pairs
… multiple path-method pairs **BREAKING CHNAGES**: - change `ProxyGetRequestLayer::new` method to support multiple path-method pairs - remove `ProxyGetRequest::new` method, which is useless
koushiro
force-pushed
the
refactor-proxy-get-request-middleware
branch
from
c62a917 to
e5ada32
Compare
|
@niklasad1 @jsdw PTAL |
niklasad1
reviewed
Nov 15, 2024
| @@ -15,27 +15,28 @@ publish = true | |||
|
|
|||
| [dependencies] | |||
| futures-util = { version = "0.3.14", default-features = false, features = ["io", "async-await-macro"] } | |||
| jsonrpsee-types = { workspace = true } | |||
There was a problem hiding this comment.
did you sort the dependencies here or why is this changed?
There was a problem hiding this comment.
Yes, this is automatically done by my vscode extension if I change the Cargo.toml.
There was a problem hiding this comment.
dq: that sounds useful, what extension are you using?
There was a problem hiding this comment.
niklasad1
approved these changes
Nov 15, 2024
lexnv
reviewed
Nov 15, 2024
lexnv
reviewed
Nov 15, 2024
lexnv
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHNAGES:
ProxyGetRequestLayer::newmethod to support multiple path-method pairsProxyGetRequest::newmethod, which is useless