Skip to content

Commit

Permalink
Fix flaky test
Browse files Browse the repository at this point in the history
  • Loading branch information
paragonie-security committed Apr 30, 2024
1 parent a2bf335 commit ca6c02d
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion tests/unit/Serializer/Signature/IEEEP1363SerializerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

use Mdanter\Ecc\Crypto\Signature\Signature;
use Mdanter\Ecc\Curves\NistCurve;
use Mdanter\Ecc\Exception\SignatureDecodeException;
use Mdanter\Ecc\Math\GmpMath;
use Mdanter\Ecc\Random\RandomGeneratorFactory;
use Mdanter\Ecc\Serializer\Signature\IEEEP1363Serializer;
Expand All @@ -24,6 +25,23 @@ public function testParsesSignature()
$this->assertEquals($expected, $serialized);
}

public function testAnnoyingCase()
{
$math = new GmpMath();
$serializer = new IEEEP1363Serializer();
$r = gmp_init('1932963615327194226947803865417518951831126771529414298593380679901691417964');
$s = gmp_init('1932963615327194226947803865417518951831126771529414298593380679901691417964');
var_dump(gmp_strval($r, 16), gmp_strval($s, 16));

$signature = new Signature($r, $s);

$serialized = $serializer->serialize($signature, 256);
$parsed = $serializer->parse($serialized);

$this->assertTrue($math->equals($signature->getR(), $parsed->getR()));
$this->assertTrue($math->equals($signature->getS(), $parsed->getS()));
}

public function testIsConsistent()
{
$math = new GmpMath();
Expand All @@ -36,7 +54,7 @@ public function testIsConsistent()
$s = $rbg->generate($max);
$signature = new Signature($r, $s);

$serialized = $serializer->serialize($signature);
$serialized = $serializer->serialize($signature, $i);
$parsed = $serializer->parse($serialized);

$this->assertTrue($math->equals($signature->getR(), $parsed->getR()));
Expand Down

0 comments on commit ca6c02d

Please sign in to comment.