Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use matching image tag as upstream hive in hive action #6288

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 30, 2024

The current upstream hive uses ghcr.io/paradigmxyz/reth:latest, see: ethereum/hive#971

Instead of pushing to paradigmxyz/reth:main, this pushes to a tag with the same name as upstream hive.

This confirmed works and now hive runs with the proper commit, see https://github.com/paradigmxyz/reth/actions/runs/7714568023/job/21028054959

Reth emits:

2024-01-30T17:13:44.120311Z  INFO reth::cli: reth 0.1.0-alpha.16 (3400493) starting

3400493 is a commit from this branch, not the published image

@Rjected Rjected added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test labels Jan 30, 2024
@Rjected Rjected force-pushed the dan/fix-hive-push-action branch from a14f8e7 to e68eadb Compare January 30, 2024 16:37
@rswanson rswanson assigned rswanson and unassigned rswanson Jan 30, 2024
@Rjected Rjected force-pushed the dan/fix-hive-push-action branch from e68eadb to 3400493 Compare January 30, 2024 16:46
@Rjected Rjected requested a review from rswanson January 30, 2024 17:25
@Rjected Rjected added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 641cb16 Jan 30, 2024
35 of 58 checks passed
@Rjected Rjected deleted the dan/fix-hive-push-action branch January 30, 2024 17:40
@rswanson rswanson mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants