test: reenable test_state_root_task test
#13911
Merged
+173
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-test
fgimenez
force-pushed
the
rkrasiuk/figure-out-whatsup-with-test
branch
from
999ab0c to
161bd66
Compare
fgimenez
force-pushed
the
rkrasiuk/figure-out-whatsup-with-test
branch
from
b3457bb to
93d135c
Compare
mattsse
approved these changes
Jan 24, 2025
crates/engine/tree/src/tree/root.rs
Outdated
Comment on lines
48
to
49
| pub(crate) fn thread_pool_size() -> usize { | ||
| std::thread::available_parallelism().map_or(4, |num| (num.get() / 2).max(4)) |
There was a problem hiding this comment.
this solution should work because it should avoid intra worker thread deadlocks but is not super ideal.
at least for this is a good enough work around, will try to come up with a better solution
rkrasiuk
commented
Jan 24, 2025
crates/engine/tree/src/tree/root.rs
Outdated
Comment on lines
48
to
49
| pub(crate) fn thread_pool_size() -> usize { | ||
| std::thread::available_parallelism().map_or(4, |num| (num.get() / 2).max(4)) |
There was a problem hiding this comment.
does this work with 3 as well?
There was a problem hiding this comment.
yep, anything above 2, pushed changes for 3
Co-authored-by: Roman Krasiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A placeholder PR to figure out why
test_state_root_taskis failing in CI.