Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add StaticFileBlockWithdrawals to db-model #13894

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat: add StaticFileBlockWithdrawals to db-model #13894

merged 1 commit into from
Jan 21, 2025

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jan 20, 2025 •
edited
Loading

Adds a type that will be used to de/serialize withdrawals from/to StaticFile::BlockMeta. This is used instead of StoredBlockWithdrawals because:

  • pre merge block withdrawals are None, which are different than []
  • static file columns/rows always require some kinda of value
  • primitive Option cannot be used as a Compact row value, and needs a wrapper struct. (eg. CompactU256, CompactU64)

@joshieDo joshieDo added C-enhancement New feature or request A-static-files Related to static files labels Jan 20, 2025
@joshieDo joshieDo mentioned this pull request Jan 20, 2025
Open
@joshieDo joshieDo force-pushed the joshie/sfw branch 3 times, most recently from b57d5e5 to 0ed10de Compare January 21, 2025 00:25
@joshieDo
Copy link
Collaborator Author

compact-codec test failure can be ignored since we're adding a new Compact type with this PR

If it happened during CI, ignore IF it's a new proposed type that `main` branch does not have.`

mattsse
mattsse approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Collaborator

mattsse commented Jan 21, 2025

ci unrelated because this introduces new test vec

@joshieDo joshieDo added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 0a5de2f Jan 21, 2025
41 of 43 checks passed
@joshieDo joshieDo deleted the joshie/sfw branch January 21, 2025 13:38
refcell pushed a commit to ethereum-optimism/op-reth that referenced this pull request Jan 24, 2025
@joshieDo @refcell
feat: add StaticFileBlockWithdrawals to db-model (paradigmxyz#13894)
77faf3b
This was referenced Jan 27, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected

@fgimenez fgimenez Awaiting requested review from fgimenez

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse