fix(trie): use correct store_in_db_trie value for sparse extension nodes
#13826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-bug
CodSpeed Performance ReportMerging #13826 will not alter performanceComparing Summary
|
mattsse
reviewed
Jan 16, 2025
crates/trie/sparse/src/trie.rs
Outdated
Comment on lines
1232
to
1234
| /// Pre-computed flag indicating whether the trie node should be stored in the database. | ||
| /// Can be reused unless this trie path has been updated. | ||
| store_in_db_trie: Option<bool>, |
There was a problem hiding this comment.
unclear here how None differs from false?
There was a problem hiding this comment.
added a comment to all fields
rkrasiuk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as we do for extension nodes.