Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snmalloc support #13771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add snmalloc support #13771

wants to merge 1 commit into from

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 10, 2025

This enables optional snmalloc support. I have not benchmarked our performance with snmalloc yet. This is implemented by adding a snmalloc feature to reth-cli-util and the reth bin, like we do with the jemalloc feature.

Instead of making these mutually exclusive features that would compile error if both are enabled, we just add a preference for jemalloc in the reth-cli-util crate. This also introduces snmalloc-native, which passes down snmalloc's native-cpu feature. This preference is explicitly documented in reth-cli-util.

@Rjected Rjected added C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint labels Jan 10, 2025
@Rjected Rjected force-pushed the dan/snmalloc-support branch from 10b5423 to cc91a7f Compare January 10, 2025 23:06
@gakonst
Copy link
Member

gakonst commented Jan 11, 2025

@hai-rise any thoughts? I know you guys like that allocator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants