feat(primitives): add constructor for BlockBody #13740
Conversation
Rjected
added
C-enhancement
| /// Returns a new instance of the [`BlockBody`]. | ||
| fn new( | ||
| transactions: &[Self::Transaction], | ||
| ommers: &[Self::OmmerHeader], | ||
| withdrawals: Option<Withdrawals>, | ||
| ) -> Self; |
There was a problem hiding this comment.
hmm, don't think we can do this because this now restricts the body to txs + ommers + withdrawals
so what if the body has an additional field?
this might perhaps not be the case but I feel like we should not freeze the body structure
There was a problem hiding this comment.
hmmm, I do need some way to transform a block for prewarming, since once we're in the engine we have no concrete types. I have to take parts of one Block and use it to create another Block with only specific transactions. Maybe we can solve this with a different type of method?
There was a problem hiding this comment.
I guess we could also solve this with a filter method on body, that returns a new body
There was a problem hiding this comment.
ah, we can just have setters
Adds a simple constructor to the
BlockBodytrait. This is similar to theBlock::newmethod.