fix(reth-trie-parallel): bump alloy-primitives and enable rayon #13618
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsing
requested review from
rkrasiuk,
Rjected,
shekhirin and
gakonst
as code owners
lightsing
changed the title
lightsing
force-pushed
the
fix/alloy-rayon
branch
from
e6f5caf to
c8f9cf8
Compare
lightsing
force-pushed
the
fix/alloy-rayon
branch
from
ee37054 to
6810c51
Compare
lightsing
changed the title
|
seems 0.8.18 already in used as in the lock file |
mattsse
approved these changes
Jan 7, 2025
mattsse
added
the
A-dependencies
|
Doesn't make much sense since no_std and parallel never happens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reth-trie-parallelcrate usesHashMap::into_par_iter(), when hashbrown backend (alloy_primitives::map::HashMap) is used, therayonfeature needs to be enabled.This feature is exported in
0.8.16, see also alloy-rs/core#827Also, the rayon
IntoItertype depends on whichHashMapbackend in used,0.8.18fix this, see also alloy-rs/core#836