Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move evm crate code into a single folder and rename crate reth-evm-ethereum to reth-ethereum-evm #13606

Closed
wants to merge 1 commit into from

Conversation

Pana
Copy link
Contributor

@Pana Pana commented Dec 31, 2024

This PR aim to:

  1. move evm code into independent crate, rather nested with two other crate
  2. rename crate reth-evm-ethereum to reth-ethereum-evm to keep consistent with reth-optimism-evm

…um to reth-ethereum-evm to keep consistent with reth-optimism-evm

fmt code
@Pana Pana force-pushed the op/evmCodeStructure branch from 01ffa56 to 5caa5c7 Compare December 31, 2024 06:41
@Pana Pana changed the title move evm code into independent crate and rename crate reth-evm-ethere… Op code structure and crate name Dec 31, 2024
@Pana Pana changed the title Op code structure and crate name Move evm crate code into a single structure and rename crate reth-evm-ethereum to reth-ethereum-evm Dec 31, 2024
@Pana Pana changed the title Move evm crate code into a single structure and rename crate reth-evm-ethereum to reth-ethereum-evm Move evm crate code into a single folder and rename crate reth-evm-ethereum to reth-ethereum-evm Dec 31, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me but I'd prefer if we could do these changes in two steps

  1. move
  2. rename ethereum crate

reth-evm = { path = "crates/evm" }
reth-evm-ethereum = { path = "crates/ethereum/evm" }
reth-evm = { path = "crates/evm/evm" }
reth-ethereum-evm = { path = "crates/ethereum/evm" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this rename, but I'd like to do this rename separately

@Pana
Copy link
Contributor Author

Pana commented Jan 7, 2025

Ok, i will create two new pr for these

@Pana Pana closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants