Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): use generic types in BlockchainProvider impl bodies #13325

Closed
wants to merge 1 commit into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Dec 11, 2024

Generalises data primitives that are now possible in BlockchainProvider impl bodies

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-db Related to the database A-sdk Related to reth's use as a library labels Dec 11, 2024
@emhane emhane requested a review from Rjected December 11, 2024 22:12
@klkvr
Copy link
Collaborator

klkvr commented Dec 11, 2024

those were kept as is intentionally because we enforce EthPrimitives in TreeNodeTypes

pub trait NodeTypesForTree:
NodeTypesForProvider<Primitives = EthPrimitives> + NodeTypesWithEngine
{
}
impl<T> NodeTypesForTree for T where
T: NodeTypesForProvider<Primitives = EthPrimitives> + NodeTypesWithEngine
{
}

we're not planning to abstract legacy engine and BlockchainProvider

@klkvr klkvr closed this Dec 19, 2024
@emhane emhane deleted the emhane/provider-cleanup branch December 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants