Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add StorageLocation to BlockBodyWriter trait #13266

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore: add StorageLocation to BlockBodyWriter trait #13266

merged 1 commit into from
Dec 10, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Dec 10, 2024 •
edited
Loading

  • moves StorageLocation to storage-api
  • adds StorageLocation arguments to BlockBodyWriter trait methods.

in preparation for #13264

@joshieDo joshieDo added A-db Related to the database A-static-files Related to static files labels Dec 10, 2024
@joshieDo joshieDo requested a review from klkvr December 10, 2024 12:01
mattsse
mattsse approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshieDo joshieDo added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 4c39b98 Dec 10, 2024
43 checks passed
@joshieDo joshieDo deleted the joshie/sl branch December 10, 2024 14:20
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@joshieDo @lean-apple
chore: add StorageLocation to BlockBodyWriter trait (paradigmxyz#…
e356dfb 
…13266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@klkvr klkvr Awaiting requested review from klkvr

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-db Related to the database A-static-files Related to static files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse