feat: SerdeBincodeCompat trait
#12991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
Rjected,
joshieDo,
emhane and
mattsse
as code owners
klkvr
force-pushed
the
klkvr/serde-bincode-compat
branch
from
cd5af67 to
dc83dc5
Compare
klkvr
force-pushed
the
klkvr/serde-bincode-compat
branch
from
2dd8c19 to
e3d1868
Compare
klkvr
force-pushed
the
klkvr/serde-bincode-compat
branch
from
e3d1868 to
7119aba
Compare
mattsse
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For integration into ExExes and HeaderStage, we need a separate serde impls appropriate for bincode serialization. Right now this is solved with helper modules but this approach doesn't work for generic primitives
This PR introduces
SerdeBincodeCompatwhich allows to specify a type representation which can be serialized using bincode.