Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic receipt ExecuteOutput #12966

Merged
merged 6 commits into from
Nov 30, 2024
Merged

feat: generic receipt ExecuteOutput #12966

merged 6 commits into from
Nov 30, 2024

Conversation

hoank101
Copy link
Contributor

Closes #12945

emhane
emhane approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

mattsse
mattsse reviewed Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this could potentially conflict with #12994

so holding off here until that one is merged

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Nov 29, 2024
Rjected
Rjected reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoank101 mind fixing conflicts? otherwise this should be good

@Rjected
Copy link
Member

Rjected commented Nov 29, 2024

actually now looking at #12994, I think that actually completes this

@hoank101
Copy link
Contributor Author

hi @Rjected resolved

@mattsse mattsse added this pull request to the merge queue Nov 30, 2024
@mattsse mattsse added A-sdk Related to reth's use as a library and removed S-blocked This cannot more forward until something else changes labels Nov 30, 2024
Merged via the queue into paradigmxyz:main with commit 7353dc9 Nov 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected left review comments

@emhane emhane emhane approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic receipt ExecuteOutput
4 participants
@hoank101 @Rjected @mattsse @emhane