Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][DOC] fix doc build #19

Merged
merged 5 commits into from
Oct 7, 2024
Merged

[FIX][DOC] fix doc build #19

merged 5 commits into from
Oct 7, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 4, 2024 •
edited
Loading

  • test doc build in CI so that it tested on PR and not just on master
  • 'silence' sphinx gallery that seems to be causing the doc build issues
  • use same build tool orchestration (make) locally and in CI

@Remi-Gau Remi-Gau changed the title [WIP][FIX][DOC] fix doc build [FIX][DOC] fix doc build Oct 7, 2024
Remi-Gau
Remi-Gau commented Oct 7, 2024
View reviewed changes
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 7, 2024

The doc can now build but I had to 'nuke' sphinx gallery to make it work. Could not yet identify the root cause of this.

Given the example in question I would suggest, keeping things that way for now so there is functioning doc build and fix the gallery later.

@Remi-Gau Remi-Gau marked this pull request as ready for review October 7, 2024 07:21
@paquiteau
Copy link
Owner

Hello Remi ! Thanks for the PR :)

Yeah the gallery can stay in oblivion until we figure out a proper example setup

@paquiteau paquiteau self-requested a review October 7, 2024 07:32
@paquiteau paquiteau merged commit 0295124 into paquiteau:master Oct 7, 2024
7 checks passed
@Remi-Gau Remi-Gau deleted the doc branch October 7, 2024 08:11
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 7, 2024

OK the doc builds but it is not deployed... will try to fix on my fork

@Remi-Gau Remi-Gau mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paquiteau paquiteau paquiteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Remi-Gau @paquiteau