-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump paperclip-macros minor #546
Conversation
@Sufflope |
I wonder if another way is to release 0.6.6 without min/max |
First let me say that I don't have previous experience with yanking, sorry (it's not a brag "I don't break things" 😅 on the contrary, it's just that I never got to maintain a public library 😢 ), so I don't have prior battle-tested knowledge. So my not-so-educated opinion is: the problem with your second approach is in the (contrived, admittedly, but technically possible) case where someone would have pinned a |
Won't it break anyway with the first approach? Because we'd be yanking the paperclip-macros pointed to by the paperclip 0.9.{0,1}? |
According to https://doc.rust-lang.org/cargo/commands/cargo-yank.html if I understand correctly, it should prevent new projects from adding paperclip 0.9.{0,1} as dependencies, but projects which have them already should continue compiling (with a warning telling them those deps are yanked). But at least users would be warned, and be able to update by switching to at least 0.9.2, instead of updating only the macro and getting a cryptic error that some fields are missing in a proc-macro. At least that's my understanding. |
Note that anyway on my side I updated all my internal projects to 0.9 and I generate min/max attributes, and I am quite aware of the problem we're discussing, so even if there's a subsequent problem with the chosen strategy, it won't be a big issue to me, so feel free to choose the strategy you think will work the best! |
Looks good to me 👍 |
Alright cool, I'll try and do this tomorrow or over the weekend, thanks both |
This is to address min/max being added and breaking back compat. paperclip-macros 0.6.4 and 0.6.5 will be yanked from crates. paperclip 0.9.0 and 0.9.1 will also be yanked from crates. Signed-off-by: Tiago Castro <[email protected]>
b12b828
to
9f2499a
Compare
This is to address min/max being added and breaking back compat. paperclip-macros 0.6.4 and 0.6.5 will be yanked from crates. paperclip 0.9.0 and 0.9.1 will also be yanked from crates.
Resolves #542