Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add instructions for git submodules #535

Conversation

RaulTrombin
Copy link
Contributor

Solves:
#534

@RaulTrombin RaulTrombin changed the title doc: Add instructions regarding submodules doc: Add instructions for git submodules Sep 10, 2024
@tiagolobocastro
Copy link
Collaborator

What about the previous suggestion of adding the git command to the make prepare command? Do you think it's better to keep as is?

@RaulTrombin
Copy link
Contributor Author

What about the previous suggestion of adding the git command to the make prepare command? Do you think it's better to keep as is?

This would also resolve the issue. I tested it on a clean clone of the repo, and it seems fine. May I go ahead and add this commit as well?

@RaulTrombin RaulTrombin force-pushed the Update_instruction_gitsubmodule branch from 463ca96 to dc795bd Compare September 10, 2024 22:20
@tiagolobocastro
Copy link
Collaborator

What about the previous suggestion of adding the git command to the make prepare command? Do you think it's better to keep as is?

This would also resolve the issue. I tested it on a clean clone of the repo, and it seems fine. May I go ahead and add this commit as well?

Yeah I think so if you don't mind

@RaulTrombin
Copy link
Contributor Author

What about the previous suggestion of adding the git command to the make prepare command? Do you think it's better to keep as is?

This would also resolve the issue. I tested it on a clean clone of the repo, and it seems fine. May I go ahead and add this commit as well?

Yeah I think so if you don't mind

did it,
removed the unnecessary aditional command if user skips submodule, as the 'make prepare' will fix it.

@tiagolobocastro tiagolobocastro merged commit 9637746 into paperclip-rs:master Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants