Store verifies digest lengths internally #6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, ensure_remote_has_recursive may return Ok even though the Digest being uploaded doesn't get uploaded.
stuhood
approved these changes
Oct 4, 2018
| Ok(bytes) => { | ||
| if bytes.len() == digest.1 { | ||
| Ok(Some(f(Bytes::from(bytes)))) | ||
| } else { |
There was a problem hiding this comment.
Does this case represent a hash collision...? If so, should we be noisier?
stuhood
approved these changes
Oct 5, 2018
|
Shard 3 is the only failure here (fixed by #6600). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, ensure_remote_has_recursive may return Ok even
though the Digest being uploaded doesn't get uploaded.