Transition panopticPool contract address to be variable #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flanagansteve
approved these changes
Sep 17, 2024
| @@ -49,6 +53,7 @@ export interface CalculateGammaResponse { | |||
|
|
|||
| export interface GreekQueryRequest extends PanopticRequest { | |||
| address: string; | |||
| panopticPool?: string, | |||
There was a problem hiding this comment.
It looks like you could just have GreekQueryRequest extend PanopticPoolRequest like the others. But maybe this was intentional because we have the possibility of making it so the params here are a token pair instead of a PanopticPool?
There was a problem hiding this comment.
The motivation for leaving this optional was to allow the possibility of using either the "internal" greek methods (no need for PanopticPool address), or the contract methods (need PanopticPool address). Easy enough to choose just one of the cases and change appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panopticPool contract address was previously hardcoded - it is made variable in this PR.
Closes #14