Bug: Inactive settings check was returning false if there was a numbe…

…r of DB settings equal of the seeder
panichelpdesk · Aug 31, 2018 · 5d58c7b · 5d58c7b
1 parent ce276c5
commit 5d58c7b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/Controllers/InstallController.php b/src/Controllers/InstallController.php
@@ -375,13 +375,14 @@ public function inactiveSettings()
         }
 
         // Application active migrations
-        $default_Settings = $seeder->getDefaults();
+        $seeder_settings = $seeder->getDefaults();
 
-        if (count($installed_settings) == count($default_Settings)) {
+		$inactive_settings = array_diff_key($seeder_settings, $installed_settings);
+
+        if (!$inactive_settings) {
             return false;
         }
-
-        $inactive_settings = array_diff_key($default_Settings, $installed_settings);
+
         return $inactive_settings;
     }