Release fix delay test #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #DEV-89
https://paneda.myjetbrains.com/youtrack/issue/DEV-89
With the massive default-buffers in ODR-DabMod, a large delay can be built up over time when mux produces data a bit faster than the modulator transmits it.
The ODR-DabMod now handles overflows in a proper manner.
Makes use of the 'max_frames_queued'-variable with some modifications and adds a 'restart_depth'-variable to odr.ini.
Buffer underruns are modified to not trigger at first appearance. It now needs 10 consecutive underrun-notifications before it exits and lets the appkeeper restart it. Sometimes a couple of underruns happens during start-up and should no longer lead to an immediate exit.
It might be possible to avoid a restart at underrun if we add code to feed the modulator old frames while we build up the buffer again... but that's for another pull-request.