Skip to content

Commit

Permalink
[HACK] Always transition to earlgrey in golden toolchain
Browse files Browse the repository at this point in the history
Unfortunately, opentitantool is far from compiling with darjeeling
due to many explicit dependencies on earlgrey. At the same time,
opentitantool provides many operations which are not earlgrey-specific
at all such as flash image generation, signing, modid checks, etc

This commit introduces a necessary hack: in the host transition
for the golden toolchain, always set the top to earlgrey. This way
we can ensure that opentitantool will compile. For now this does
not introduce any problem but this is not a proper fix.

Signed-off-by: Amaury Pouly <[email protected]>
  • Loading branch information
pamaury committed Dec 16, 2024
1 parent 954bbcb commit a046d64
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions rules/host.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ def _host_tools_transition_impl(settings, attr):
"//hw/bitstream/universal:rom": "//hw/bitstream/universal:none",
"//hw/bitstream/universal:otp": "//hw/bitstream/universal:none",
"//hw/bitstream/universal:env": "//hw/bitstream/universal:none",
# WARNING This is a horrible hack: when we transition to host, we pretend
# that this is earlgrey so opentitantool can compile...
"//hw/top": "earlgrey",
}
return ret

Expand All @@ -39,5 +42,6 @@ host_tools_transition = transition(
"//hw/bitstream/universal:rom",
"//hw/bitstream/universal:otp",
"//hw/bitstream/universal:env",
"//hw/top",
],
)

0 comments on commit a046d64

Please sign in to comment.