Merge stable into main #2830
Open
Merge stable into main #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… into trim_args_section
…m_args_section
Co-authored-by: Andreas Backx <[email protected]>
Co-authored-by: Andreas Backx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges stable into main but there's an openstanding problem that might needs fixing on stable before we merge into main.
Stable has moved from os.system to subprocess. As part of this, it also extended some testing for
echo_with_pager. One test leveragescat > PATHwhich due to how the move to subprocess went, is no longer supported. We can decide to:I think to reduce the load and focus on future development, let's go with 2. The impact for users is the following:
PAGERsetup including something that needs to be run in a shell, won't be used in 8.1.8. It will fallback to one of the pagers we try.I think this is acceptable. Please let me know what you think.