-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clinic card screens #13
base: master
Are you sure you want to change the base?
Conversation
Still needs some work though.
…ycles' period days
Kept the range selection of days
Can you share some few screens? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And did you fix the responsiveness, the over flows on the self screening module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using static data? Kindly check. We want to do away with most of the static data files.
@@ -328,7 +328,7 @@ class _ChatScreenState extends ConsumerState<ChatScreen> { | |||
setState(() { | |||
_consent = !_consent; | |||
}); | |||
_updateConsent(type == ConsentType.accept ? true : false); | |||
_updateConsent(_consent); | |||
Navigator.of(context).pop(); | |||
}, | |||
child: const Text('Yes'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some of these texts as constatnts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are not using this file we can delete it.
final Map<String, String> svgMapping = { | ||
"allergies": "assets/images/boldDuotoneMedicineVirus.svg", | ||
"immunization": "assets/images/boldDuotoneMedicineSyringe.svg", | ||
"conditions": "assets/images/boldDuotoneMedicineStethoscope.svg", | ||
"labResults": "assets/images/boldDuotoneMedicineTestTube.svg", | ||
"medications": "assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
"procedures": "assets/images/boldDuotoneMedicineBone.svg", | ||
"vitals": "assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
}; | ||
|
||
final List<String> items = [ | ||
"Allergies", | ||
"Conditions", | ||
"Immunizations", | ||
"Lab Results", | ||
"Medications", | ||
"Procedures", | ||
"Vitals" | ||
]; | ||
|
||
final List<String> icons = [ | ||
// "assets/images/boldDuotoneFoldersFolderPathConnect.svg", | ||
"assets/images/boldDuotoneMedicineVirus.svg", | ||
"assets/images/boldDuotoneMedicineStethoscope.svg", | ||
"assets/images/boldDuotoneMedicineSyringe.svg", | ||
"assets/images/boldDuotoneMedicineTestTube.svg", | ||
"assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
"assets/images/boldDuotoneMedicineBone.svg", | ||
"assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to think of a better way to present this.
final Map<String, String> svgMapping = { | ||
"allergies": "assets/images/boldDuotoneMedicineVirus.svg", | ||
"conditions": "assets/images/boldDuotoneMedicineStethoscope.svg", | ||
"immunization": "assets/images/boldDuotoneMedicineSyringe.svg", | ||
"labResults": "assets/images/boldDuotoneMedicineTestTube.svg", | ||
"medications": "assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
"procedures": "assets/images/boldDuotoneMedicineBone.svg", | ||
"vitals": "assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
}; | ||
|
||
final List<String> items = [ | ||
"Allergies", | ||
"Conditions", | ||
"Immunizations", | ||
"Lab Results", | ||
"Medications", | ||
"Procedures", | ||
"Vitals" | ||
]; | ||
|
||
final List<String> icons = [ | ||
"assets/images/boldDuotoneMedicineVirus.svg", | ||
"assets/images/boldDuotoneMedicineStethoscope.svg", | ||
"assets/images/boldDuotoneMedicineSyringe.svg", | ||
"assets/images/boldDuotoneMedicineTestTube.svg", | ||
"assets/images/boldDuotoneMedicineJarOfPills2.svg", | ||
"assets/images/boldDuotoneMedicineBone.svg", | ||
"assets/images/boldDuotoneMedicineHeartPulse2.svg" | ||
]; | ||
|
||
final List<String> paths = [ | ||
RouteNames.ALLERGY_HEALTH_RSHIP_RECORD, | ||
RouteNames.HEALTH_RSHIP_RECORD, | ||
RouteNames.IMMUNIZATION_RSHIP_RECORD, | ||
RouteNames.LAB_RESULTS_HEALTH_RSHIP_RECORD, | ||
RouteNames.MEDICATION_RSHIP_RECORD, | ||
RouteNames.PROCEDURE_RSHIP_RECORD, | ||
RouteNames.VITAL_HEALTH_RSHIP_RECORD, | ||
|
||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We think on how to simplify this
children: [ | ||
_buildDateRow(record.visitDate, theme), | ||
const SizedBox(height: Constants.SPACING), | ||
_buildHospitalRow(record.facility, theme), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were to remove the facility names from the cards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DependentClinicCard.mp4
Yeah, next pr will resolve this and screen_overflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are merging to master don't you think we should just fix them in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also work, so let me highlight the specific items to be resolve first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vicky-ogutu for good work!
static const TOKEN_KEY = 'jwt_token_key'; | ||
static const SPACING = 10.0; | ||
static const SPACINGA = 10.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to review this spacing
@@ -104,11 +104,16 @@ class _SelfScreeningState extends ConsumerState<SelfScreening> { | |||
crossAxisAlignment: CrossAxisAlignment.start, | |||
children: [ | |||
// Cards showing health data | |||
Wrap( | |||
Padding( | |||
padding: const EdgeInsets.symmetric(horizontal: 8.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use Constants
const Divider(), | ||
// _buildHospitalRow(record.facility, theme), | ||
// const SizedBox(height: Constants.SPACING), | ||
// const Divider(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We remove commented out code
Is this done now? And are we not merging this to 2_0_1 first? |
Share the latest video, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Screenshot and or Video
CustomAppBar( | ||
title: "Facility Directory 🏥", | ||
subTitle: 'Some very long sub title', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not remove this text.
This is well noted, Thanks for this..
…On Mon, Jan 20, 2025 at 5:29 PM Ogollah ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/src/features/art/presentation/FacilityDirectory.dart
<#13 (comment)>
:
> CustomAppBar(
title: "Facility Directory 🏥",
+ subTitle: 'Some very long sub title',
You did not remove this text.
—
Reply to this email directly, view it on GitHub
<#13 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQEOPVAFVFWE3BFTHNVBXJT2LUB5PAVCNFSM6AAAAABTOUFZ2SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRSGUZTKMRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
all screens for dependent's clinic-card