Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add notification for HIE sync failure #558

Merged
merged 18 commits into from
Jan 20, 2025

Conversation

FelixKiprotich350
Copy link
Contributor

@FelixKiprotich350 FelixKiprotich350 commented Jan 20, 2025

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Notify user when HIE sync fails on the backend

Screenshots

Screenshot from 2025-01-20 21-55-19

Related Issue

None.

Other

None.

@FelixKiprotich350
Copy link
Contributor Author

@donaldkibet @ojwanganto have a look

@ojwanganto
Copy link
Contributor

Thanks, @FelixKiprotich350. @makombe @donaldkibet please have a look.

makombe
makombe previously approved these changes Jan 20, 2025
Copy link
Collaborator

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FelixKiprotich350 LGTM

@@ -28,6 +22,13 @@ const FacilityInfo: React.FC = () => {
kind: 'success',
isLowContrast: true,
});
if (defaultFacility?.source != 'HIE') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an error or just a notification?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what set's the defaultFacility variable?

Copy link
Contributor Author

@FelixKiprotich350 FelixKiprotich350 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojwanganto youre right should be a notification ,,,but of kind warning. (pink one)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojwanganto also updated screenshot

@donaldkibet donaldkibet merged commit b3d3f18 into palladiumkenya:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants