-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add notification for HIE sync failure #558
Conversation
@donaldkibet @ojwanganto have a look |
Thanks, @FelixKiprotich350. @makombe @donaldkibet please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FelixKiprotich350 LGTM
@@ -28,6 +22,13 @@ const FacilityInfo: React.FC = () => { | |||
kind: 'success', | |||
isLowContrast: true, | |||
}); | |||
if (defaultFacility?.source != 'HIE') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an error or just a notification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what set's the defaultFacility variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ojwanganto youre right should be a notification ,,,but of kind warning. (pink one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ojwanganto also updated screenshot
Requirements
Summary
Notify user when HIE sync fails on the backend
Screenshots
Related Issue
None.
Other
None.