(feat): Add user role scope #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makombe
reviewed
Jan 20, 2025
Comment on lines
91
to
93
| licenseNumber: providerAttributeType.find((type) => type.name === 'Practising License Number')?.uuid || '', | ||
| licenseExpiry: providerAttributeType.find((type) => type.name === 'License Expiry Date')?.uuid || '', | ||
| primaryFacility: providerAttributeType.find((type) => type.name === 'Primary Facility')?.uuid || '', |
There was a problem hiding this comment.
@Ogollah Can we check for the uuids here instead of name? Names are always volatile and can be changed any time.
| display: role.display, | ||
| description: role.description, | ||
| })) || [], | ||
| gender: initialUserValue.person?.gender || 'M', |
There was a problem hiding this comment.
Why is the gender or here explicitly M ? should it be empty?
makombe
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
What does this PR do?
Screenshots
userScope.webm
None.
Related Issue
None.
Other
None.