feat: KHP3 follow up changes on the providers: Filters, UI #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Jan 17, 2025
packages/esm-providers-app/src/component/providers.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-providers-app/src/table/provider-data-table.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-providers-app/src/table/provider-data-table.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-providers-app/src/table/provider-details.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-providers-app/src/workspace/provider-form.workspace.tsx
Outdated
Show resolved
Hide resolved
|
@donaldkibet @patryllus @ojwanganto any reactions??
|
|
Thanks, @its-kios09. This looks really nice. Is it possible to move from the expanded section to the table? It will look better in that point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I needed to add a comment on the provider attribute for the HIE FHIR bundle reference being persisted. It is breaking because the omod I have is missing the following constant: public static final String PROVIDER_HIE_FHIR_REFERENCE = "67b94e8e-4d61-4810-b0f1-d86497f6e553";
Additionally, based on suggestions from today’s meeting, the following fields should be set to read-only: license, National ID, registration number, and expiry date to prevent them from being modified.
Screenshots
None.
Related Issue
None.
Other
None.