Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHP3-6234: Enhanced Case Management Functionality: CRUD Operations, Table Integration, and Conditional Dropdown Behavior #285

Merged

Conversation

its-kios09
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

see https://thepalladiumgroup.atlassian.net/browse/KHP3-6234

Screenshots

complete

None.

Related Issue

None.

Other

None.

Copy link
Contributor

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @its-kios09

@use '@carbon/layout';
@use '@carbon/colors';
@use '@carbon/type';
@import '~@openmrs/esm-styleguide/src/vars';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@import '~@openmrs/esm-styleguide/src/vars';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could stop depending on this import would be great

@@ -97,6 +103,9 @@ export const labourAndDelivery = getSyncLifecycle(LabourDelivery, options);
export const caseManagementDashboardLink = getSyncLifecycle(createLeftPanelLink(caseManagementDashboardMeta), options);
export const wrapComponent = getSyncLifecycle(WrapComponent, options);
export const caseManagementForm = getSyncLifecycle(CaseManagementForm, options);
export const caseEncounterDashboardLink = getSyncLifecycle(createDashboardLink(caseEncounterDashboardMeta), options);
// export const caseEncounterHeader = getSyncLifecycle(CaseEncounterHeader, options);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// export const caseEncounterHeader = getSyncLifecycle(CaseEncounterHeader, options);

@donaldkibet donaldkibet merged commit a133306 into palladiumkenya:main Jul 25, 2024
7 checks passed
@donaldkibet donaldkibet deleted the itskios-09/case-encounters branch July 25, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants