Adds get_build_path to BuildableTemplateView, which can handle a build_path property set to reverse_lazy #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a
get_build_path
method to BuildableTemplateView. This coerces thebuild_path
property to text, and strips any preceding '/
', which allows us to set build_path toreverse_lazy
values. This partially resolves issue #120 (we're not handling 'directory' paths yet).There is some related further work I'd like to complete, but I didn't want to create a huge diff in one pull request. If this gets accepted, I'll continue work on:
build_path
(andreverse_lazy
) values which do not include an explicit filename (similar to howBuildableDetailView
works), e.g. handling a value of "/about/
", without having to specify "about/index.html
". This would include a setting to allow an alternative "default" filename, rather than hard-coding 'index.html
' in python code in multiple places.