Improvement: report unauthorized error as a health check #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamDeHovitz
commented
May 12, 2021
| @@ -66,7 +74,7 @@ func (h *healthHandlerImpl) computeNewHealthStatus(req *http.Request) (health.He | |||
| if sharedSecret := h.healthCheckSharedSecret.CurrentString(); sharedSecret != "" { | |||
| token, err := httpserver.ParseBearerTokenHeader(req) | |||
| if err != nil || sharedSecret != token { | |||
| return health.HealthStatus{}, http.StatusUnauthorized | |||
| return healthStatusUnauthorized, http.StatusUnauthorized | |||
There was a problem hiding this comment.
My preference was to log when we hit this case but there's no accessible ctx and the loggingHealthStatusChangeHandler used above derives the status code from the health status rather than from the status returned by computeNewHealthStatus
added 2 commits
May 12, 2021 14:13
…antir/witchcraft-go-server into ad/unauthorized_health_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We believe we hit this case last week but it's difficult to confirm due to a lack of logging and the way an empty health status get's reported in autopilot.
After this PR
==COMMIT_MSG==
If user is unauthorized to view health checks return an unauthorized error health check rather than no health check.
==COMMIT_MSG==
Possible downsides?
Possibly confusing to users/might interact poorly if existing monitoring/error catching depends on an empty health status object.
This change is