Use project version as default tag #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
reviewed
Dec 13, 2021
| } | ||
|
|
||
| @Deprecated | ||
| public void tags(String... args) { | ||
| this.tags = ImmutableSet.copyOf(args) | ||
| this.tags.set(ImmutableSet.copyOf(args)) |
There was a problem hiding this comment.
Hmm, from memory wasn't the way this used to work that people would put
docker {
tags 'latest'
}but it would still make the version tag? I wonder if we just want to make getTags() return tags.get() + [version]?
There was a problem hiding this comment.
Updated to add the version tag to the other tags if it does not exist already.
However, I'm actually not 100% sure where the version tag came from before. E.g. a bunch of projects would not specify any tags and still get the correct publish.
CRogers
approved these changes
Jan 4, 2022
|
Released 0.32.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
With #506, we added a regression that not all docker images would be pushed if no tags were specified explicitly.
This is because the tasks
dockerTagsPushanddockerPushare just marker tasks that run the respective tag and push tasks for all tags. However, when no tags are specified, no sub-tasks will be created and run as the below closure is skipped:gradle-docker/src/main/groovy/com/palantir/gradle/docker/PalantirDockerPlugin.groovy
Line 148 in db4cfe1
After this PR
To work-around this, we add the project version as a default tag, if not other tags are specified. This will per-default tag and push an image with the current project version.
==COMMIT_MSG==
Use project version as default tag
==COMMIT_MSG==