-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document versions.props comment format #1129
Open
ash211
wants to merge
4
commits into
develop
Choose a base branch
from
aash/test-VersionsProps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ash211
changed the title
Add more tests for current VersionsProps behavior
Document current versions.props comment format
Feb 13, 2024
ash211
changed the title
Document current versions.props comment format
Document versions.props comment format
Feb 13, 2024
ash211
commented
Feb 13, 2024
void ignores_comment_on_same_line_with_no_hash() throws IOException { | ||
Path propsFile = tempDir.resolve("versions.props"); | ||
Files.writeString( | ||
propsFile, "com.palantir.test:test = 1.0.0 comment on same line with no hash", StandardCharsets.UTF_8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems less than ideal, but I'm not sure we gain much by making this invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Expected
versions.props
comment format is not documented: https://github.com/palantir/gradle-consistent-versions?tab=readme-ov-file#versionsprops-lower-bounds-for-dependenciesAfter this PR
==COMMIT_MSG==
Document current
versions.props
comment format==COMMIT_MSG==
This also adds test coverage for the documented comment formats, plus some other comment behaviors that currently exist. I'm not sure the test case in
ignores_comment_on_same_line_with_no_hash()
is ideal, but supporting that behavior doesn't seem to be hurting much.Possible downsides?
None known