use findByType when not sure if java plugin exists (#1231)

use findByType when not sure if java plugin exists #1231
palantir · Sep 16, 2024 · 6b89b09 · 6b89b09
1 parent 9345584
commit 6b89b09
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog/@unreleased/pr-1231.v2.yml b/changelog/@unreleased/pr-1231.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: use findByType when not sure if java plugin exists
+  links:
+  - https://github.com/palantir/gradle-consistent-versions/pull/1231
diff --git a/src/main/java/com/palantir/gradle/versions/GradleConfigurations.java b/src/main/java/com/palantir/gradle/versions/GradleConfigurations.java
@@ -54,7 +54,7 @@ public static Set<Configuration> getResolvableConfigurations(Project project) {
      * applied, this returns an empty set.
      */
     private static Set<String> getLegacyJavaConfigurations(Project project) {
-        JavaPluginExtension javaConvention = project.getExtensions().getByType(JavaPluginExtension.class);
+        JavaPluginExtension javaConvention = project.getExtensions().findByType(JavaPluginExtension.class);
         if (javaConvention == null) {
             return ImmutableSet.of();
         }