safe-logging analysis correctly handles out-of-scope parameter references #2988
+31
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
commented
Jan 8, 2025
| // JCBindingPattern is newer than our compilation target, so we match strings to avoid | ||
| // complex build-system configurations. | ||
| String kindString = enclosing.getKind().name(); | ||
| return "BINDING_PATTERN".equals(kindString); |
There was a problem hiding this comment.
not sure why I originally checked for an enclosing binding pattern instead of the binding variable type before, most likely searching in the dark based on older jdk-11 sources
|
Looks like this would catch some log safety issues in my repo. Looking forward to having this additional protection land! |
|
Released 6.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #2984
==COMMIT_MSG==
safe-logging analysis correctly handles out-of-scope parameter references
==COMMIT_MSG==
Note that this has also been updated to improve the
isPatternBindingcheck using java 17 target compatibility now that we've upgraded.This should dramatically improve performance in areas which reference parameters in lambdas as well, as we can avoid an additional set of compilations :-)