FIxup

palantir · Jul 16, 2021 · f05d200 · f05d200
1 parent f08a004
commit f05d200
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/...e-core/src/main/java/com/palantir/dialogue/core/BalancedNodeSelectionStrategyChannel.java b/...e-core/src/main/java/com/palantir/dialogue/core/BalancedNodeSelectionStrategyChannel.java
@@ -47,7 +47,7 @@
  * workloads (where n requests must all land on the same server) or scenarios where cache warming is very important.
  * {@link PinUntilErrorNodeSelectionStrategyChannel} remains the best choice for these.
  */
-final class BalancedNodeSelectionStrategyChannel implements LimitedChannel {
+final class BalancedNodeSelectionStrategyChannel implements NodeSelectingChannel {
     private static final Logger log = LoggerFactory.getLogger(BalancedNodeSelectionStrategyChannel.class);
 
     private static final int INFLIGHT_COMPARISON_THRESHOLD = 5;
@@ -127,6 +127,11 @@ public Optional<ListenableFuture<Response>> maybeExecute(
         return Optional.empty();
     }
 
+    @Override
+    public void routeToHost(int index, Request request) {
+        StickyAttachments.routeToChannel(request, channels.get(index));
+    }
+
     private static final class BalancedChannel implements LimitedChannel {
         private final LimitedChannel delegate;
         private final ChannelScoreInfo channelInfo;

diff --git a/dialogue-core/src/main/java/com/palantir/dialogue/core/NodeSelectionStrategyChannel.java b/dialogue-core/src/main/java/com/palantir/dialogue/core/NodeSelectionStrategyChannel.java
@@ -84,7 +84,7 @@ static NodeSelectingChannel create(Config cf, ImmutableList<LimitedChannel> chan
                 private LimitedChannel delegate = channels.get(0);
 
                 @Override
-                public void routeToHost(int index, Request request) {
+                public void routeToHost(int _index, Request request) {
                     StickyAttachments.routeToChannel(request, delegate);
                 }
 

diff --git a/dialogue-core/src/main/java/com/palantir/dialogue/core/ZeroUriNodeSelectionChannel.java b/dialogue-core/src/main/java/com/palantir/dialogue/core/ZeroUriNodeSelectionChannel.java
@@ -45,7 +45,7 @@ public Optional<ListenableFuture<Response>> maybeExecute(
     }
 
     @Override
-    public void routeToHost(int index, Request request) {
+    public void routeToHost(int _index, Request _request) {
         throw new SafeIllegalStateException(
                 "There are no URIs configured to handle requests", SafeArg.of("channel", channelName));
     }

diff --git a/...c/test/java/com/palantir/dialogue/core/PinUntilErrorNodeSelectionStrategyChannelTest.java b/...c/test/java/com/palantir/dialogue/core/PinUntilErrorNodeSelectionStrategyChannelTest.java
@@ -76,8 +76,8 @@ public void before() {
                         channels, pseudo, clock, metrics, channelName);
 
         pinUntilErrorWithoutReshuffle =
-                new PinUntilErrorNodeSelectionStrategyChannel(constantList, 1, metrics, channelName);
-        pinUntilError = new PinUntilErrorNodeSelectionStrategyChannel(shufflingList, 1, metrics, channelName);
+                new PinUntilErrorNodeSelectionStrategyChannel(null, constantList, 1, metrics, channelName);
+        pinUntilError = new PinUntilErrorNodeSelectionStrategyChannel(null, shufflingList, 1, metrics, channelName);
     }
 
     @Test