wip: refreshable *tls.Config support for CGR clients #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
bmoylan
reviewed
Dec 18, 2024
|
|
||
| "github.com/palantir/pkg/refreshable" | ||
| "github.com/palantir/pkg/tlsconfig" | ||
| werror "github.com/palantir/witchcraft-go-error" | ||
| "github.com/palantir/witchcraft-go-logging/wlog/svclog/svc1log" | ||
| ) | ||
|
|
||
| type RefreshableTLSConf interface { |
There was a problem hiding this comment.
nit: Spell out RefreshableTLSConfig to match tls.Config
| _, ok := r.Current().(*tls.Config) | ||
| if !ok { | ||
| // TODO(smenon): proper error msg. | ||
| return errors.New("invalid type for refreshable") |
There was a problem hiding this comment.
generally we are ok with panicking if the type of a refreshable is incorrect (as it's programmer error and should easily get caught the first time the code runs) so I don't think you need NewValidatingRefreshable here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?