Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Unexport field of unexported and non-serialized structs #547

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

improvement: Unexport field of unexported and non-serialized structs #547

wants to merge 2 commits into from

Conversation

splucs
Copy link

@splucs splucs commented Oct 6, 2023

No description provided.

bmoylan
bmoylan requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bmoylan bmoylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason in particular we need to do this?

@splucs
Copy link
Author

splucs commented Oct 25, 2023

No, just clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoylan bmoylan bmoylan requested changes

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splucs @bmoylan @svc-changelog