improvement: Make TLSConfig refreshable #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splucs
commented
Oct 6, 2023
| return err | ||
| } else if tlsConfig != nil { |
There was a problem hiding this comment.
Because of the subscription to the security config, this should always return a non-nil refreshable.
added 3 commits
October 5, 2023 19:38
…jure-go-runtime into lfdo/refreshable-tls-config
bmoylan
reviewed
Nov 21, 2023
|
|
||
| return newTLSConfig(currentSecurity) | ||
| security.SubscribeToSecurityConfig(func(currentSecurity SecurityConfig) { | ||
| currentTLSConfig, err := newTLSConfig(currentSecurity) |
There was a problem hiding this comment.
Do we care that this does not handle changing file contents, only file paths?
| }) | ||
|
|
||
| if tlsConfig != nil { | ||
| tlsConfig.Subscribe(func(tlsConfI interface{}) { |
There was a problem hiding this comment.
The general concern I had with the original implementation was this subscription because *tls.Config is not compatible with reflect.DeepEqual (it contains closures in struct fields) so other changes could cause us to rebuild our transport (and lose shared connections)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow updating the TLS config whenever there's a change to security files such as certs and CAs.