improvement: Implement balanced scorer as URISelector #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrejod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Referencing the new URIScorer interface from #349, we add a implementation of the URIScorer for the balanced URI scoring algorithm. Reference the original Balancer scorer algo here:
https://github.com/palantir/conjure-go-runtime/blob/develop/conjure-go-client/httpclient/internal/balanced_scorer.go
After this PR
We now have a URIScorer for the balanced algo. The balanced algo tracks the number of inflight requests, and server side errors in order to minimize the number of requests sent to servers with too many requests/failures.
==COMMIT_MSG==
Implement balanced scorer as URISelector
==COMMIT_MSG==
Reference original PR adding balanced algo: #208
Possible downsides?
This change is