[#IOPID-1604] redirect to confirm page #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-1604 |
Terraform Plan 📖Terraform Plan�[0m�[1mInitializing the backend...�[0m
�[0m�[32m
Successfully configured the backend "azurerm"! Terraform will automatically
use this backend unless the backend configuration changes.�[0m
�[0m�[1mInitializing provider plugins...�[0m
- Finding hashicorp/azurerm versions matching ">= 3.30.0, <= 3.40.0"...
- Installing hashicorp/azurerm v3.40.0...
- Installed hashicorp/azurerm v3.40.0 (signed by HashiCorp)
Terraform has created a lock file �[1m.terraform.lock.hcl�[0m to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.�[0m
�[0m�[1m�[32mTerraform has been successfully initialized!�[0m�[32m�[0m
�[0m�[32m
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.�[0m
Acquiring state lock. This may take a few moments...
data.azurerm_resource_group.this: Reading...
data.azurerm_resource_group.this: Read complete after 0s [id=/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards]
No changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
Releasing state lock. This may take a few moments...
|
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
arcogabbo
requested review from
pagopa-github-bot and
silvicir
and removed request for
a team
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
BurnedMarshal
suggested changes
Feb 28, 2024
gquadrati
reviewed
Feb 28, 2024
utils/middleware.ts
Outdated
Comment on lines
10
to
30
| export const TokenQueryParam = PatternString( | ||
| "^[A-Za-z0-9]{26}:[A-Fa-f0-9]{24}$" | ||
| ); | ||
| export type TokenQueryParam = t.TypeOf<typeof TokenQueryParam>; | ||
|
|
||
| export const TokenQueryParamMiddleware = RequiredQueryParamMiddleware( | ||
| "token", | ||
| TokenQueryParam | ||
| ); | ||
|
|
||
| // CONFIRM -> verify token and on success redirect to confirm page | ||
| // VALIDATE -> verify token and on success redirect to result page | ||
| export enum FlowChoiceEnum { | ||
| "CONFIRM" = "CONFIRM", | ||
| "VALIDATE" = "VALIDATE" | ||
| } | ||
| export const FlowChoice = enumType<FlowChoiceEnum>( | ||
| FlowChoiceEnum, | ||
| "FlowChoice" | ||
| ); | ||
| export type FlowChoice = t.TypeOf<typeof FlowChoice>; |
There was a problem hiding this comment.
Is it possible for us to generate them from the OpenAPI specification?
There was a problem hiding this comment.
that's what I thought at first. sadly, the OpenAPI spec in the project is only used for opex dashboards(introduced on latest versions) and the codebase is not based on the types generated from it. so I continued with the pattern already used.
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
|
arcogabbo
temporarily deployed
to
opex-prod-ci
GitHub Actions
Inactive
BurnedMarshal
approved these changes
Feb 29, 2024
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
new optional query parameter for redirecting the user on a new confirm page
How Has This Been Tested?
unit tests, integration tests via
io-mockScreenshots (if appropriate):
Types of changes
Checklist: