Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sl_SI in the PreferredLanguage enum #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sl_SI in the PreferredLanguage enum #332

wants to merge 1 commit into from

Conversation

francescopersico
Copy link
Contributor

List of Changes

Add sl_SI in the PreferredLanguage enum

Motivation and Context

We need to allow also the Slovene language as preferred

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@francescopersico francescopersico requested a review from a team as a code owner April 6, 2023 09:04
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Jira Pull request Link

It seems this Pull Request has no issues that refers to Jira!!!
Please check it out.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmnplb dmnplb mentioned this pull request Apr 6, 2023
Closed
fabriziopapi
fabriziopapi approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@fabriziopapi fabriziopapi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a minor question: we do not have translation for greenpass in slovene.
@dmnplb @thisisjp

@thisisjp
Copy link

@fabriziopapi DGC platform only supports French and German, so we don't have any official translation. Is this a blocker? Or we'll simply show the italian certificate to users who are using IO in Slovenian?

@fabriziopapi
Copy link
Contributor

@fabriziopapi DGC platform only supports French and German, so we don't have any official translation. Is this a blocker? Or we'll simply show the italian certificate to users who are using IO in Slovenian?

It's not a blocker: it will fallback to english as default.

@thisisjp
Copy link

@fabriziopapi ok, then let's merge it 🙏 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopapi fabriziopapi fabriziopapi approved these changes

@arcogabbo arcogabbo Awaiting requested review from arcogabbo arcogabbo is a code owner automatically assigned from pagopa/io-backend-contributors

@AndreaPagoPa AndreaPagoPa Awaiting requested review from AndreaPagoPa AndreaPagoPa is a code owner automatically assigned from pagopa/io-backend-contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francescopersico @thisisjp @fabriziopapi