-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(IT Wallet): [SIW-2006] Replace ItwMarkdown
with IOMarkdown
and improve TOS WebView
#6663
base: master
Are you sure you want to change the base?
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6663 +/- ##
==========================================
- Coverage 50.04% 50.02% -0.02%
==========================================
Files 1544 1544
Lines 32163 32156 -7
Branches 7291 7242 -49
==========================================
- Hits 16096 16087 -9
- Misses 16016 16030 +14
+ Partials 51 39 -12
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
This PR replaces
ItwMarkdown
, now removed, with the newIOMarkdown
component. In this PR there is also an improvement of the IPZS TOS WebView.List of changes proposed in this pull request
ItwMarkdown
and replaced every reference with theIOMarkdown
componentgenerateLinkRuleWithCallback
utility function which returns the rule for theLink
component with the ability to pass a callback to run when the user clicks on an url.twIpzsPrivacyScreen
adding theIOScrollView
componentItwPrivacyWebViewComponent
to allow auto-resize on content loadedHow to test
Test on both iOS and Android the issuance flows and check that everything is displayed correctly.