Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(IT Wallet): [SIW-2006] Replace ItwMarkdown with IOMarkdown and improve TOS WebView #6663

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 31, 2025

Short description

This PR replaces ItwMarkdown, now removed, with the new IOMarkdown component. In this PR there is also an improvement of the IPZS TOS WebView.

List of changes proposed in this pull request

  • Removed ItwMarkdown and replaced every reference with the IOMarkdown component
  • Added generateLinkRuleWithCallback utility function which returns the rule for the Link component with the ability to pass a callback to run when the user clicks on an url.
  • Refactored twIpzsPrivacyScreen adding the IOScrollView component
  • Refactored ItwPrivacyWebViewComponent to allow auto-resize on content loaded

How to test

Test on both iOS and Android the issuance flows and check that everything is displayed correctly.

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@mastro993 mastro993 self-assigned this Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.02%. Comparing base (211d849) to head (f48797a).

Files with missing lines Patch % Lines
ts/features/itwallet/common/utils/markdown.tsx 42.85% 4 Missing ⚠️
...iscovery/components/ItwPrivacyWebViewComponent.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6663      +/-   ##
==========================================
- Coverage   50.04%   50.02%   -0.02%     
==========================================
  Files        1544     1544              
  Lines       32163    32156       -7     
  Branches     7291     7242      -49     
==========================================
- Hits        16096    16087       -9     
- Misses      16016    16030      +14     
+ Partials       51       39      -12     
Files with missing lines Coverage Δ
...es/itwallet/common/hooks/useItwInfoBottomSheet.tsx 100.00% <100.00%> (ø)
...allet/discovery/screens/ItwDiscoveryInfoScreen.tsx 86.66% <ø> (ø)
...twallet/discovery/screens/ItwIpzsPrivacyScreen.tsx 66.66% <ø> (ø)
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 34.21% <ø> (ø)
...res/itwallet/playgrounds/screens/ItwPlayground.tsx 11.11% <ø> (-8.89%) ⬇️
ts/utils/webview.ts 90.00% <100.00%> (+1.11%) ⬆️
...iscovery/components/ItwPrivacyWebViewComponent.tsx 66.66% <66.66%> (-33.34%) ⬇️
ts/features/itwallet/common/utils/markdown.tsx 42.85% <42.85%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211d849...f48797a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant