Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:[IOPID-2162] Remove CieID FF #6653

Merged
merged 19 commits into from
Feb 5, 2025
Merged

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Jan 29, 2025

Short description

This PR removes the local and the remote CieID Feature Flags and fixes the cieLogin migration config

List of changes proposed in this pull request

  • Removed all the references related to the local and the remote CieID FF
  • Fixed cieLoginReducer migration
  • Removed the Spid/Cie login buttons inversion logic
  • Removed the ts/components/cie/CieNotSupported.tsx screen
  • Removed the CieID switch from ts/screens/profile/DeveloperModeSection.tsx
  • Updated the LandingScreen tests
  • Updated the snapshots in order to reflect the changes after the removal of the CieID FF

How to test

Run the app in both iOS and Android devices and ensure that everything works properly. The login with CieID should be always available and, in case of a first app install, the the Tooltip should be prompted over the Cie login button.

Tip

If you want to test the scenario where the device does not support login with CIE+PIN from a device that does support it, simply invert the value of isCieSupported in the file ts/hooks/useNavigateToLoginMethod.tsx. This way, you will notice that the two buttons are no longer swapped, and when clicking on "Login with CIE", the bottom sheet will not be displayed, but instead, the navigation will go directly to the CieID login.

@ChrisMattew ChrisMattew self-assigned this Jan 29, 2025
@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.03%. Comparing base (435848a) to head (ac038f1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/cieLogin/store/reducers/index.ts 33.33% 2 Missing ⚠️
ts/screens/authentication/LandingScreen.tsx 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6653      +/-   ##
==========================================
- Coverage   50.04%   50.03%   -0.01%     
==========================================
  Files        1539     1538       -1     
  Lines       32170    32126      -44     
  Branches     7295     7232      -63     
==========================================
- Hits        16100    16075      -25     
+ Misses      16019    16013       -6     
+ Partials       51       38      -13     
Files with missing lines Coverage Δ
ts/features/cieLogin/store/actions/index.ts 100.00% <ø> (ø)
ts/features/cieLogin/store/selectors/index.ts 83.33% <100.00%> (-9.53%) ⬇️
ts/navigation/AuthenticationNavigator.tsx 40.00% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/screens/profile/DeveloperModeSection.tsx 25.38% <ø> (-0.94%) ⬇️
ts/store/reducers/index.ts 40.74% <ø> (ø)
ts/features/cieLogin/store/reducers/index.ts 61.90% <33.33%> (+2.81%) ⬆️
ts/screens/authentication/LandingScreen.tsx 80.43% <77.77%> (-0.13%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435848a...ac038f1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants