-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:[IOPID-2162] Remove CieID FF #6653
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6653 +/- ##
==========================================
- Coverage 50.04% 50.03% -0.01%
==========================================
Files 1539 1538 -1
Lines 32170 32126 -44
Branches 7295 7232 -63
==========================================
- Hits 16100 16075 -25
+ Misses 16019 16013 -6
+ Partials 51 38 -13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
This PR removes the local and the remote
CieID
Feature Flags and fixes thecieLogin
migration configList of changes proposed in this pull request
CieID
FFcieLoginReducer
migrationts/components/cie/CieNotSupported.tsx
screenCieID
switch fromts/screens/profile/DeveloperModeSection.tsx
LandingScreen
testsCieID
FFHow to test
Run the app in both
iOS
andAndroid
devices and ensure that everything works properly. The login withCieID
should be always available and, in case of a first app install, the theTooltip
should be prompted over theCie
login button.Tip
If you want to test the scenario where the device does not support login with CIE+PIN from a device that does support it, simply invert the value of
isCieSupported
in the filets/hooks/useNavigateToLoginMethod.tsx
. This way, you will notice that the two buttons are no longer swapped, and when clicking on "Login with CIE", the bottom sheet will not be displayed, but instead, the navigation will go directly to theCieID
login.