Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPFD0-29] Add Slovenian localization #4344

Closed
wants to merge 9 commits into from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Feb 3, 2023

Short description

Thanks to the valuable contribution by @damjang, this PR enables the Slovenian localization in the IO app.

List of changes proposed in this pull request

  • Move the entire original sl folder (from the previous PR) to the new updated environment.
  • Add the various locale settings to the codebase, according to internal guidelines

How to test

Go to the Profile → Preferences → Language → Select Slovenian

@dmnplb dmnplb added the i18n Activities related to internationalization label Feb 3, 2023
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPFD0-29] Add Slovenian localization chore: [IOAPPFD0-29] Add Slovenian localization Feb 3, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 3, 2023

Affected stories

  • ⚙️ IOAPPFD0-29: Aggiunta della localizzazione in sloveno

Generated by 🚫 dangerJS against b65ae6b

@Vangaorth
Copy link
Contributor

@dmnplb I applied the content of this PR to the one with the slovenian translations. Both this and that require additional work for the remote generated file that does not have support for the language.
Do you prefer to keep this PR in draft/open mode or is it closable?

@damjang
Copy link

damjang commented Feb 17, 2023

Hi to all! Thank you for working on the Slovenian translation. If I can help with something -but not with coding-, please tell me.

@dmnplb
Copy link
Contributor Author

dmnplb commented Feb 17, 2023

@dmnplb I applied the content of this PR to the one with the slovenian translations. Both this and that require additional work for the remote generated file that does not have support for the language. Do you prefer to keep this PR in draft/open mode or is it closable?

Let's close this PR in favour of the @damjang's one, so we can keep the correct authorship of the changed lines. We can continue the conversation in the original PR.

@damjang, thanks again for your contribution.

@dmnplb dmnplb closed this Feb 17, 2023
@dmnplb dmnplb deleted the IOAPPFD0-29-i18n-slovenian branch February 17, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Activities related to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants